[Webkit-unassigned] [Bug 102061] New: [EFL] Fix build warning in NetworkStateNotifierEfl.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 02:00:02 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102061

           Summary: [EFL] Fix build warning in NetworkStateNotifierEfl.cpp
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit EFL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ktf.kim at samsung.com
                CC: demarchi at webkit.org
            Blocks: 101761


To fix the below build warning:
 Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:110:130: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

The second argument for NLMSG_OK need to be unsigned because it is compared with 'unsigned int'.

http://lxr.free-electrons.com/source/include/linux/netlink.h#L86
 41 struct nlmsghdr {
 42         __u32           nlmsg_len;      /* Length of message including header */
 43         __u16           nlmsg_type;     /* Message content */
 44         __u16           nlmsg_flags;    /* Additional flags */
 45         __u32           nlmsg_seq;      /* Sequence number */
 46         __u32           nlmsg_pid;      /* Sending process port ID */
 47 };

 86 #define NLMSG_OK(nlh,len) ((len) >= (int)sizeof(struct nlmsghdr) && \
 87                            (nlh)->nlmsg_len >= sizeof(struct nlmsghdr) && \
 88                            (nlh)->nlmsg_len <= (len))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list