[Webkit-unassigned] [Bug 101563] Add support for fractional scroll events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101563





--- Comment #22 from Adam Barth <abarth at webkit.org>  2012-11-12 23:20:01 PST ---
(From update of attachment 173584)
View in context: https://bugs.webkit.org/attachment.cgi?id=173584&action=review

>> Source/Platform/chromium/public/WebInputHandlerClient.h:27
>> +#include "config.h"
> 
> Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]

You cannot include config.h in any API headers (any headers that contain "public" in their path).

> Source/Platform/chromium/public/WebInputHandlerClient.h:63
> +#if PLATFORM(CHROMIUM)
>      virtual void scrollBy(WebPoint, WebSize) = 0;
> +#else
> +    virtual void scrollBy(WebPoint, WebFloatPoint) = 0;
> +#endif

This file is used only by Chromium.  Having a PLATFORM(CHROMIUM) ifdef here does not make any sense.  Instead, you'll probably need to create a new ifdef to represent this change so you can land it without breaking the Chromium compile.  After this patch is rolled in the Chromium, you can update all the code in svn.chromium.org to use the new API (and to define the ifdef).  Then you can delete the ifdef and the old API from svn.webkit.org.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.