[Webkit-unassigned] [Bug 102000] [EFL][WK2] White flicker when scrolling big pages with dark background on slower hardware.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102000





--- Comment #8 from Viatcheslav Ostapenko <ostap73 at gmail.com>  2012-11-12 23:02:47 PST ---
(In reply to comment #7)
> (From update of attachment 173814 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173814&action=review
> 
> This will not work with semi-transparent backgrounds or with non rectangular clip, as it uses glClear and friends which completely clear the pixels in a given rectangle.
> I suggest that instead of this we expose backgroundColor from DrawingAreaProxy, and let the embedded (ewk_view?) decide what and how to clear.

So, every port will have its own code for this?

> > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:96
> > +    , m_backgroundColor(255, 255, 255, 255)
> 
> Color::white()

Ok

> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:768
> > +    m_webPage->send(Messages::LayerTreeCoordinatorProxy::SetBackgroundColor(color));
> 
> So we do this on every layout? seems wasteful. Maybe we should make sure that the color has actually changed?

Ok

> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2770
> > +        WebCore::Color color = WebCore::Color(float(red), float(green), float(blue), float(alpha));
> 
> Color color(red, green, blue, alpha);

Doesn't work. red, green, blue and alpha are doubles. There is 2 constructors for Color - with 4 ints and 4 floats. Compiler cannot decide which constructor to use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.