[Webkit-unassigned] [Bug 101978] Web Inspector: Fix docking behaviour on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101978





--- Comment #2 from Tim Horton <timothy_horton at apple.com>  2012-11-12 14:17:10 PST ---
(From update of attachment 173710)
View in context: https://bugs.webkit.org/attachment.cgi?id=173710&action=review

> Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:143
> +    // Call setDockingUnavailable before bringToFront. If we display the inspector's HWND first it causes the call to canAttachWindow to return the wrong result.

I wonder if you can talk about this in a more generic way. Using the word HWND in cross-platform code is weird (at the very least, note that this is Windows only).
Also, what/why does it cause canAttachWindow to return the wrong result?

> Source/WebKit/win/ChangeLog:8
> +        There are a number of problems for docking behaviour on Windows.

s/for/with/

> Source/WebKit/win/ChangeLog:9
> +        For starters it does not ever constrain the inspectors size properly while docked.

s/For starters/For starters,/
s/inspectors/inspector's/

> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:296
> +    // We need to set the attached windows height before we actually attach the window.

s/windows/window's/

> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:297
> +    // Make sure that m_attached is true so that setAttachedWindowHeight succeeds.

s/succeeds/doesn't return early/?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.