[Webkit-unassigned] [Bug 101473] Optimize RGBA4444ToRGBA8 packing/unpacking functions with NEON intrinsics in GraphicsContext3D

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101473





--- Comment #8 from Zoltan Herczeg <zherczeg at webkit.org>  2012-11-12 09:55:51 PST ---
(From update of attachment 173654)
Nice. Few more things, and this patch is ready:

View in context: https://bugs.webkit.org/attachment.cgi?id=173654&action=review

> Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h:2
> + * Copyright (C) 2012 University of Szeged

You could also mention your name here.

> Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h:74
> +        uint8x8x2_t RGBA;
> +        RGBA.val[0] = vorr_u8(componentB, componentA);
> +        RGBA.val[1] = vorr_u8(componentR, componentG);
> +        vst2_u8(dst, RGBA);

For me the "components" and "RGBA" names are not exactly consistent. Perhaps you could use RGBA4 and RGBA8 instead of them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.