[Webkit-unassigned] [Bug 101192] [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101192


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173595|review?                     |review-
               Flag|                            |




--- Comment #6 from Adam Barth <abarth at webkit.org>  2012-11-12 09:48:10 PST ---
(From update of attachment 173595)
View in context: https://bugs.webkit.org/attachment.cgi?id=173595&action=review

This isn't how we normally handle these cases.  Why not just have Chromium use WebSettings to enable Regions?

> Source/WebCore/page/Settings.cpp:218
> -#if ENABLE(CSS_REGIONS)
> +#if ENABLE(CSS_REGIONS) && !USE(V8)

We generally don't have USE(V8) ifdefs in Settings.cpp....

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.