[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #53 from Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk>  2012-11-12 09:29:32 PST ---
(In reply to comment #52)
> (In reply to comment #51)
> > (From update of attachment 173334 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=173334&action=review
> > 
> > > Source/WebKit2/UIProcess/InspectorServer/WebSocketServerConnection.cpp:82
> > > -    // If this ASSERT happens on any platform then their SocketStreamHandle::send
> > > -    // followed by a SocketStreamHandle::close is not guarenteed to have sent all
> > > -    // data. If this happens, we need to slightly change the design to include a
> > > -    // SocketStreamHandleClient::didSend, handle it here, and add an m_shutdownAfterSend
> > > -    // state on this WebSocketServerConnection.
> > > -    ASSERT(!m_socket->bufferedAmount());
> > > +    if (m_socket->bufferedAmount()) {
> > > +        m_shutdownAfterSend = true;
> > > +        return;
> > > +    }
> > 
> > The only concern I still have is this, since the comment has not been fully applied, I'm not 100% sure this is acting as expected. If you could double-check with the person who wrote the comment that would be great, otherwise looks fine to me.
> 
> Hi, from functionality point of view it follows the comment. I will check with the person who left the comment anyway, and if he is unhappy for the reason I can always submit another patch to fix it. Current solution seems to work flawlessly for me.

Can you check if this patch compiles on a debug build, please?
Looks like WebContextGtk.cpp uses Log but it doesn't include the header.

It compiles fine on a release build, but debug is failing here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.