[Webkit-unassigned] [Bug 101913] Remove HTMLInputElement dependency from PickerIndicatorElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101913


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173596|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2012-11-12 02:54:08 PST ---
(From update of attachment 173596)
View in context: https://bugs.webkit.org/attachment.cgi?id=173596&action=review

The code looks ok.  One comment.

> Source/WebCore/html/shadow/PickerIndicatorElement.h:53
> +        virtual bool isPickerIndicatorOwnerDisabled() const = 0;
> +        virtual bool isPickerIndicatorOwnerReadOnly() const = 0;

They are called together every time.  So we may merge them into one function like isPickerIndicatorOwnerDisabledOrReadOnly(). This pattern is used in FieldOwner in WebCore/html/shadow/DateTimeFieldElement.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.