[Webkit-unassigned] [Bug 101740] [Qt][ARM]REGRESSION(r133985): It broke the build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101740





--- Comment #11 from Balazs Kilvady <kilvadyb at homejinni.com>  2012-11-09 09:30:14 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > hmmm... maybe if I move the implementation of the emit{Int32,Double,..}PutByVal to the corresponding cpp it would be ok with the templates, but then it should be in both cpps.
> 
> I tried moving the implementation of these methods to the general parot of the JITPropertyAccess.cpp file, but The error message remained. After thinking it through the same situation occured.
> 
> So I think there is only 2 possible solution:
>  1) use the my first patch which removes the template or
>  2) move the emit{Int32,..}PutByVal implementation to both JITPropertyAccess files and there will be code duplication.

In JITPropertyAccess.cpp there is a emitGenericContiguousPutByVal implementation for JSVALUE64 case. When I move the 32 bit implementation of the template function from JITPropertyAccess32_64.cpp to JITPropertyAccess.cpp then the Int32 and Double typed version of the template won't be optimized out and tests are successful with the compiled jsc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.