[Webkit-unassigned] [Bug 99660] checkbox to toggle FPS counter in the inspector's settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99660





--- Comment #44 from egraether at chromium.org  2012-11-09 09:21:54 PST ---
(From update of attachment 173319)
View in context: https://bugs.webkit.org/attachment.cgi?id=173319&action=review

resolved the nits:

> Source/WebCore/inspector/Inspector.json:351
> +                    { "name": "show", "type": "boolean", "description": "True if the FPS count can be shown" }

reordered and renamed return values

> Source/WebCore/inspector/InspectorClient.h:75
> +    virtual bool canShowFPSCounter() { return false; }

reordered and moved up

> Source/WebCore/inspector/InspectorPageAgent.cpp:714
> +void InspectorPageAgent::canShowFPSCounter(ErrorString*, bool* outParam)

reordered

> Source/WebCore/inspector/InspectorPageAgent.h:112
> +    virtual void canShowFPSCounter(ErrorString*, bool*);

reordered

> Source/WebKit/chromium/src/InspectorClientImpl.cpp:166
> +bool InspectorClientImpl::canShowFPSCounter()

reordered and moved up

> Source/WebKit/chromium/src/InspectorClientImpl.h:80
> +    virtual bool canShowFPSCounter();

reordered and moved up

> Source/WebKit/chromium/src/WebViewImpl.h:654
> +    void loadFontAtlasIfNecessary();

The declaration and definition order is a bit chaotic in WebViewImpl. I moved the declaration right after setIsAcceleratedCompositingActive() to match the definition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.