[Webkit-unassigned] [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 9 04:57:19 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=90968
--- Comment #28 from Peter Gal <galpeter at inf.u-szeged.hu> 2012-11-09 04:58:55 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=172596&action=review
> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:696
> +void DumpRenderTree::setArgTimeout(double timeout)
> +{
> + if (timeout > 0)
> + DumpRenderTree::setTimeout(timeout);
> +}
> +
Why do we need this at all? Couldn't be this in the processLine method? (Also a simple setTimout(timeout) call should be enough I think.)
> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:730
> + DumpRenderTree::setArgTimeout(command.timeout);
no need for the 'DumpRenderTree::' if I'm correct. Also shouldn't this be before the if case? there is a return inside the else case.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list