[Webkit-unassigned] [Bug 100937] [BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100937


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173220|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #7 from Rob Buis <rwlbuis at gmail.com>  2012-11-09 04:35:23 PST ---
(From update of attachment 173220)
View in context: https://bugs.webkit.org/attachment.cgi?id=173220&action=review

LGTM.

> Tools/ChangeLog:12
> +        KeyUp event in InputHandler::handleKeyboardInput().

No PR?

> Tools/DumpRenderTree/blackberry/EventSender.cpp:185
> +    page->keyEvent(BlackBerry::Platform::KeyboardEvent(charCode, BlackBerry::Platform::KeyboardEvent::KeyUp, modifiers));

We should be considering using BlackBerry::Platform::KeyboardEvent; to get rid of the namespaces. You'd need just KeyboardEvent then.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.