[Webkit-unassigned] [Bug 99578] [EFL] Share WebKit-Gtk's Accessibility implementation with others WebKit ports.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 02:21:04 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=99578





--- Comment #21 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-11-09 02:22:39 PST ---
Attachment 170877 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp:167:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp:342:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp:343:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:206:  webkit_accessible_parent_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:624:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:747:  webkit_accessible_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:771:  type_volatile is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:788:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:968:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:972:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:210:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:217:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.h:49:  parent_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.h:52:  webkit_accessible_get_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 17 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list