[Webkit-unassigned] [Bug 99578] [EFL] Share WebKit-Gtk's Accessibility implementation with others WebKit ports.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99578





--- Comment #19 from Mario Sanchez Prada <mario at webkit.org>  2012-11-09 02:07:59 PST ---
(In reply to comment #18)
> > Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:582
> > +    notImplemented()
> 
> Missing semicolon.
> 
> > Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:592
> > +    notImplemented()
> 
> Missing semicolon.
>
> > Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:246
> > +#endif // PLATFORM(GTK)
> 
> Compilation error on other platforms.
> Should be moved two lines forward.

Oops! Sometimes I'm so absentminded... thanks for catching these.

> > Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:248
> >          }
> 
> #endif // PLATFORM(GTK)
> Should be placed here.
> 
> Would like me to continue this bug ?. I think it can be already shipped to 
> mainstream. I found only some minor mistakes

No problem. If the patches are good for you already as they are (as it seems to be), I think I can do it myself. Actually I have filed a new bug for the first part (see bug 101727) and plan to provide an updated patch for the second one (moving from gtk/ to atk/) now.

> Patches do not make any problems on GTK regarding a11y layout tests.
> Results are the same before and after the change.
> 
> Found 157 tests; running 138, skipping 19.
> All 138 tests run as expected.

Great! Happy to help

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.