[Webkit-unassigned] [Bug 101607] Web Inspector: stop using cursorCoords in CodeMirrorTextEditor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101607





--- Comment #1 from Jan Keromnes <janx at chromium.org>  2012-11-08 08:10:26 PST ---
(In reply to comment #6 bug 99319)
> (From update of attachment 173038 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173038&action=review
> 
> > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:-57
> > -    CodeMirror.on(this._codeMirror, "change", this._change.bind(this));
> 
> Why this was wrong? It seems to work for me.

Using the global `CodeMirror.on(instance, event)` function C-style is not wrong, but I think that the `instance.on(event)` variant is less confusing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.