[Webkit-unassigned] [Bug 101568] [BlackBerry] need to call closePopup at setValueAndClosePopup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101568


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172981|review?                     |review-
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2012-11-08 07:31:27 PST ---
(From update of attachment 172981)
View in context: https://bugs.webkit.org/attachment.cgi?id=172981&action=review

Code looks good but ChangeLog should be better.

> Source/WebKit/blackberry/ChangeLog:10
> +        Internally reviewed by Charles Wei.

Please also state PR and internal reviewer.
I think the description could be better, since in the PR it states there is a freeze/crash which I can't see in this description.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.