[Webkit-unassigned] [Bug 99660] toggle FPS counter option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99660





--- Comment #32 from Andrey Kosyakov <caseq at chromium.org>  2012-11-08 07:08:29 PST ---
(From update of attachment 172629)
View in context: https://bugs.webkit.org/attachment.cgi?id=172629&action=review

>> Source/WebCore/inspector/InspectorPageAgent.cpp:722
>> +    *outParam = m_page->settings()->forceCompositingMode();
> 
> I renamed the capability check to canShowFPSCounter, but I'm not yet sure where to put the check for compositing mode best, so that it fits chromium and works for other embedders.

Do you think we should only support FPS counters if compositing is forced? I thought that would be almost never for the majority of the users. So my ideas was that we perhaps should always show the checkbos for chrome, but only honor it when in accelerated compositing (whether forced or not).

> Source/WebCore/inspector/InspectorPageAgent.h:113
> +    virtual void canShowFPSCounter(ErrorString*, bool* outParam);

drop outParam in declaration, just bool*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.