[Webkit-unassigned] [Bug 101006] Text Autosizing: Change m_textAutosizingFontScaleFactor to double type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101006


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX




--- Comment #14 from Julien Chaffraix <jchaffraix at webkit.org>  2012-11-07 10:53:45 PST ---
> Julien, Would let me know the example of "We may as well do the conversion at the Settings level (as we are doing now) and let the API take the value they want." ?

I don't have a specific example in mind, most API convert the type at the WebKit level to match what WebCore expected (qfloat -> float for Qt, ...). Here we couldn't make the 2 types agree which is why we should just decouple the 2 and do the conversion when crossing the WebKit / WebCore border (which is what I meant by the "conversion at the Settings level").

There seem to be some agreement that the existing code is fine, closing the bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.