[Webkit-unassigned] [Bug 98715] [EFL] Enable -Werror for the EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98715





--- Comment #14 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-11-07 06:40:40 PST ---
(From update of attachment 172650)
View in context: https://bugs.webkit.org/attachment.cgi?id=172650&action=review

> Source/cmake/WebKitHelpers.cmake:-40
> -        SET(OLD_COMPILE_FLAGS "-DANOTHER_BRICK_IN_THE -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}")

-DANOTHER_BRICK_IN_THE -Wall is a long standing joke on the CMake buildsystem, I think it should stay.

> Source/cmake/WebKitHelpers.cmake:45
> +        SET(OLD_COMPILE_FLAGS "-Werror -Wno-error=unused-parameter -Wno-error=switch -Wno-error=sign-compare -Wno-error=unused-function ${OLD_COMPILE_FLAGS}")

I would write this as SET(OLD_COMPILE_FLAGS ${OLD_COMPILE_FLAGS} ...) to make it explicit that you are appending parameters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.