[Webkit-unassigned] [Bug 101392] [EFL] Simplify the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101392





--- Comment #6 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-11-06 16:29:53 PST ---
(In reply to comment #3)
> (From update of attachment 172648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172648&action=review
> 
> > Source/cmake/OptionsEfl.cmake:178
> > -  SET(WTF_USE_ACCELERATED_COMPOSITING 1)
> >    ADD_DEFINITIONS(-DWTF_USE_ACCELERATED_COMPOSITING=1)
> 
> Is this still needed after WTF_USE_ACCELERATED_COMPOSITING was moved to platform.h ?

At the moment WTF_USE_ACCELERATED_COMPOSITING is only enabled in OptionsEfl.cmake for EFL. 

I agree in that once we enable WTF_USE_ACCELERATED_COMPOSITING by default for EFL, it is best to do it in Platform.h and not in OptionsEfl.cmake. 

 /* Accelerated compositing */
-#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))
+#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))

Until this change is not made, we still need the above line in OptionsEfl.cmake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.