[Webkit-unassigned] [Bug 100173] Re-order variables in BidiRun and LayoutState

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 14:42:59 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=100173





--- Comment #8 from Chris Evans <cevans at google.com>  2012-11-06 14:44:31 PST ---
@eseidel: Thanks for the comments and sorry for the slow action. I was scared of the efficiency of bitfields but after an hour playing with compilers and asm, I see that my fears were largely unfounded. In fact, clang (as used on Mac AFAIK) generates very compact / fast initialization code for bitfields.
Your point about layering violation is noted. I'll rename the field to reflect it's generic subclass-defined efficient storage and abstract away m_hasHyphen into a simple getter.

@inferno: with the bitfields approach suggested by @eseidel, the "dummy" variable is unnecessary. I'll recalculate the savings and update the ChangeLog with more verbosity as requested.

Updated patch forthcoming.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list