[Webkit-unassigned] [Bug 101193] [EFL][WK2] Add ewk_database_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101193





--- Comment #15 from Jihye Kang <jye.kang at samsung.com>  2012-11-06 05:30:43 PST ---
(In reply to comment #13)
> (From update of attachment 172550 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172550&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.h:190
> > + * @param context context object to query.
> 
> Do not use . at the end of line. We haven't been used . at @ field.

I will follow the policy.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.h:192
> > + * @return Ewk_Database_Manager object instance or @c NULL in case of failure.
> 
> ditto.

I will follow the policy.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_database_manager.cpp:67
> > +struct Ewk_Database_Origins_Async_Get_Context {
> 
> If this struct is used for callback, don't you need to add this to below ?
> 
> http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/efl/EwkViewCallbacks.h#L34

This struct is used for storing data for callback function, static getDatabaseOriginsCallback() which is needed to get asynchronous data from ewk_database_manager_origins_get(). Because it is not a structure for ewk view callback, I think I don't need to add this to EwkViewCallbacks.h.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_database_manager.h:48
> > + * @brief Callback type for use with ewk_database_manager_origins_get().
> 
> ditto ?

I will follow the policy.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_database_manager_private.h:46
> > +    explicit Ewk_Database_Manager(WKDatabaseManagerRef databaseManagerRef);
> 
> It looks databseManagerRef is not meaningful. I think Data type is enough.

I will remove databaseManagerRef. And let only data type exists on the param.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.