[Webkit-unassigned] [Bug 101193] [EFL][WK2] Add ewk_database_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101193





--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-11-06 04:55:53 PST ---
(From update of attachment 172550)
View in context: https://bugs.webkit.org/attachment.cgi?id=172550&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:190
> + * @param context context object to query.

Do not use . at the end of line. We haven't been used . at @ field.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:192
> + * @return Ewk_Database_Manager object instance or @c NULL in case of failure.

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_database_manager.cpp:67
> +struct Ewk_Database_Origins_Async_Get_Context {

If this struct is used for callback, don't you need to add this to below ?

http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/efl/EwkViewCallbacks.h#L34

> Source/WebKit2/UIProcess/API/efl/ewk_database_manager.h:48
> + * @brief Callback type for use with ewk_database_manager_origins_get().

ditto ?

> Source/WebKit2/UIProcess/API/efl/ewk_database_manager_private.h:46
> +    explicit Ewk_Database_Manager(WKDatabaseManagerRef databaseManagerRef);

It looks databseManagerRef is not meaningful. I think Data type is enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.