[Webkit-unassigned] [Bug 101193] [EFL][WK2] Add ewk_database_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101193





--- Comment #10 from Jihye Kang <jye.kang at samsung.com>  2012-11-06 03:14:01 PST ---
(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > (From update of attachment 172452 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=172452&action=review
> > > 
> > > >> Source/WebKit2/UIProcess/API/efl/ewk_context_private.h:58
> > > >> +    Ewk_Database_Manager* databaseManager() const;
> > > > 
> > > > Should not be const as per WebKit coding style.
> > > 
> > > or should return const pointer, as far as I see there are only const methods in the interface
> > 
> > But I might add non-const methods in database manager interface later. So I think I need to use const_cast on getter for database manager rather than making databaseManager() as const function. Is it webkit preferred style?
> 
> which other methods would you need? 
> if so, you will add another method: Ewk_Database_Manager* databaseManager();
> and invoke it from non-const pointer to context.
> 
> In general const_cast is better, as it makes it obvious that you break constness.
some kind of clear and setting methods. 
So I need to use const cast. Thanks for the advice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.