[Webkit-unassigned] [Bug 101291] [EFL] Refactor GraphicsContext3DEFL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 01:18:28 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101291





--- Comment #6 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-11-06 01:19:58 PST ---
(From update of attachment 172498)
View in context: https://bugs.webkit.org/attachment.cgi?id=172498&action=review

> Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:65
> +    DEFINE_STATIC_LOCAL(OwnPtr<GLNativeContext>, sharing, (createOffScreenContext()));

why OwnPtr here?

> Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:111
> +    for (size_t i = 0; i < contextList.size(); ++i)

re-calculating the size each time?

> Source/WebCore/platform/graphics/efl/GLNativeContext.h:46
> +    virtual PlatformGraphicsContext3D handle() = 0;

const method?

> Source/WebCore/platform/graphics/efl/GLNativeContext.h:49
> +    virtual bool isCurrentContext() = 0;

const method?

> Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:87
> +    void doPopContext();

do we really need this method? isn't popContex enough?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list