[Webkit-unassigned] [Bug 101291] [EFL] Refactor GraphicsContext3DEFL

Tue Nov 6 00:18:13 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=101291

--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-11-06 00:19:44 PST ---
Attachment 172498 did not pass style-queue:

Source/WebCore/platform/graphics/efl/GLNativeContext.h:21:  #ifndef header guard has wrong style, please use: GLNativeContext_h  [build/header_guard] [5]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:24:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:36:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:40:  The parameter name "renderStyle" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:40:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:40:  Extra space between static and PassOwnPtr  [whitespace/declaration] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:62:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.h:69:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:21:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:22:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:33:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:43:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:47:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:120:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:122:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLNativeContext.cpp:181:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:81:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:83:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:84:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:86:  Declaration has space between type name and * in GLContextGLX *sharedContext  [whitespace/declaration] [3]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:89:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:139:  Extra space between return and m_platformContext  [whitespace/declaration] [3]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.cpp:145:  Extra space before ) in if  [whitespace/parens] [5]
Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.h:49:  The parameter name "pageClient" adds no information,Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/PlatformEfl.cmake', u'Sourc..." exit_code: 1
 so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:55:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:42:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:57:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:60:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:218:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:26:  #ifndef header guard has wrong style, please use: GLXContextWrapper_h  [build/header_guard] [5]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:42:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:44:  "GL/glx.h" already included at Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:31  [build/include] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:52:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:58:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:64:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:76:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/efl/GLXContextWrapper.h:79:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 44 in 8 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.