[Webkit-unassigned] [Bug 101187] Reduce the memory usage of ConvolverNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101187





--- Comment #5 from Xingnan Wang <xingnan.wang at intel.com>  2012-11-05 22:22:38 PST ---
(In reply to comment #4)
> The memory saving looks good, but I'm a bit concerned about the CPU hit, any comments about that?

There are not obvious difference of CPU usage before and after applying my patch from my test. For the dram machine demo(http://chromium.googlecode.com/svn/trunk/samples/audio/shiny-drum-machine.html), the CPU hit nearly doesn't change. And the memory usage reduce ~40M, which it should come from ConvolverNode.

The patch should not increase the CPU usage for the convolver, because I just replace multiply of the non-interleaved data with multiply of interleaved data and avoid the interleaving/de-interleaving before and after the "multiply()". But for getting the non-interleaving data(from the two functions real() and imag()), it needs to do the in-place shuffle which may consume some more CPU, but it's not in the hot path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.