[Webkit-unassigned] [Bug 101241] [EFL] [WK2] Random crash in Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101241





--- Comment #4 from Viatcheslav Ostapenko <ostap73 at gmail.com>  2012-11-05 14:09:14 PST ---
(In reply to comment #3)
> (From update of attachment 172381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172381&action=review
> 
> We should not be switching AC off and on as you are describing. 

It also happens if webprocess crashes.
I've spent some time to figure out why it switches of AC in webprocess, but it is difficult to reproduce. I was able to get is several times clicking on demos on this page: http://webdesignerwall.com/trends/47-amazing-css3-animation-demos
With debugger attached to webprocess I was not able to reproduce it.

>IMO, the proper solution is to move the initialization and cleanup code out of EnterAcceleratedCompositing/ExitAcceleratedCompositing. No other port implements these methods.
> 
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:194
> > +    Evas_GL* evasGL() const { return m_evasGL.get(); }
> > +    Evas_GL_Context* evasGLContext() const { return m_evasGLContext ? m_evasGLContext->context() : 0; }
> > +    Evas_GL_Surface* evasGLSurface() const { return m_evasGLSurface ? m_evasGLSurface->surface() : 0; }
> 
> Adding these const is against the latest webkit coding style.

Wow. 
Do you have some reference?
At least style checker didn't complain ;)
Those "const" mean that method don't change object and optimizer can do something with them. Previously there was single call to those method in function, but now I've added 2nd one, so it is better go give some hint to compiler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.