[Webkit-unassigned] [Bug 101241] [EFL] [WK2] Random crash in Minibrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 13:46:20 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101241





--- Comment #3 from Yael <yael at webkit.org>  2012-11-05 13:47:49 PST ---
(From update of attachment 172381)
View in context: https://bugs.webkit.org/attachment.cgi?id=172381&action=review

We should not be switching AC off and on as you are describing. IMO, the proper solution is to move the initialization and cleanup code out of EnterAcceleratedCompositing/ExitAcceleratedCompositing. No other port implements these methods.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:194
> +    Evas_GL* evasGL() const { return m_evasGL.get(); }
> +    Evas_GL_Context* evasGLContext() const { return m_evasGLContext ? m_evasGLContext->context() : 0; }
> +    Evas_GL_Surface* evasGLSurface() const { return m_evasGLSurface ? m_evasGLSurface->surface() : 0; }

Adding these const is against the latest webkit coding style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list