[Webkit-unassigned] [Bug 98665] Remove <wtf/Platform.h> include from header files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98665





--- Comment #13 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2012-11-05 11:52:02 PST ---
(From update of attachment 167561)
View in context: https://bugs.webkit.org/attachment.cgi?id=167561&action=review

>> Source/JavaScriptCore/API/tests/minidom.c:33
>> +#include <wtf/Platform.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Another way to fix this is to create a a prefix header for the minidom target, or to include the "config.h" header in all of the source files in API/tests.

>> Source/JavaScriptCore/API/tests/testapi.c:32
>> +#include <wtf/Platform.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Another way to fix this is to create a a prefix header for the minidom target, or to include the "config.h" header in all of the source files in API/tests.

> Source/WTF/wtf/Assertions.h:-45
> -#include <wtf/Platform.h>

This may need to be added back in the short term to address any build failures, although I think this is correct in the long term.  (Unless there is a special exception for Assertions.h, although I'm not aware of why that would be the case.)

Any project which uses WTF headers needs to know about <wtf/Platform.h> at a project level, which means it should appear in config.h or the project's prefix header.  That's true of JavaScriptCore, WebCore, WebKit and WebKit2 since they all include wtf/Platform.h in their project's config.h header (JSC, WebCore) or prefix header (WebKit) or both (WebKit2).

> Tools/DumpRenderTree/mac/MockGeolocationProvider.mm:26
> +#include <wtf/Platform.h>

Instead of including wtf/Platform.h here, it should include config.h instead:

#import "config.h"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.