[Webkit-unassigned] [Bug 101224] [GTK] Check DOM bindings API compatibility while building

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101224


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-11-05 09:43:49 PST ---
(In reply to comment #3)

> > > Source/WebCore/bindings/gobject/GNUmakefile.am:484
> > > +	&& (cmp -s $@ $(WebCore)/bindings/gobject/webkitdom.symbols || $(PYTHON) $(WebCore)/bindings/scripts/gobject-check-api $@ $(WebCore)/bindings/gobject/webkitdom.symbols) \
> > 
> > I'm curious why you don't just use the diff tool here.
> 
> I'm assuming it's faster to use cmp when the files are the same than running the python script.

I was wondering if the entire script just be replaced entirely by careful execution of the diff command?

> I followed the same approach than the other bindings scripts like gobject-generate-headers.pl

Then perhaps gobject-detect-api-breaks would be a better name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.