[Webkit-unassigned] [Bug 101224] [GTK] Check DOM bindings API compatibility while building

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101224





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-11-05 09:16:27 PST ---
(From update of attachment 172342)
View in context: https://bugs.webkit.org/attachment.cgi?id=172342&action=review

> Source/WebCore/bindings/gobject/GNUmakefile.am:484
> +	&& (cmp -s $@ $(WebCore)/bindings/gobject/webkitdom.symbols || $(PYTHON) $(WebCore)/bindings/scripts/gobject-check-api $@ $(WebCore)/bindings/gobject/webkitdom.symbols) \

I'm curious why you don't just use the diff tool here.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1484
> +    # Write a symbols file.
> +    my $symbolsFileName = "$outputDir/" . $basename . ".symbols";
> +    open(SYM, ">$symbolsFileName") or die "Couldn't open file $symbolsFileName";
> +    print SYM @symbols;
> +    close(SYM);

Instead of four symbols files, I wonder if there could only be one.

> Source/WebCore/bindings/scripts/gobject-check-api:1
> +#!/usr/bin/env python

Just a naming nit: This should probably be called detect-gobject-api-breaks or something like that, especially with the verb first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.