[Webkit-unassigned] [Bug 101223] [BlackBerry] ImageDiff build clean-up

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101223





--- Comment #3 from Ming Xie <mxie at rim.com>  2012-11-05 09:04:44 PST ---
(In reply to comment #2)
> (From update of attachment 172338 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review
> 
> Looks good, can be made a bit more robust.
> 
> > Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6
> > +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff"
> 
> It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that.

Yeah, It may also be a good idea to not use QMake here. Let me re-think about this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.