[Webkit-unassigned] [Bug 101224] [GTK] Check DOM bindings API compatibility while building

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101224


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172342|                            |review?
               Flag|                            |




--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-11-05 08:46:42 PST ---
Created an attachment (id=172342)
 --> (https://bugs.webkit.org/attachment.cgi?id=172342&action=review)
Patch

There's something I'm not sure about in this patch. It keeps a symbols file in the source tree to compare with the symbols generated during the build and if the changes are API comapatible the symbols file in the source tree is updated. I'm not sure it's a good idea that the build updates a file in the source tree. Most of the times the API changes, we don't notice it, so if the file has to be update manually, we will miss it most of the times. We could make the build fail even for compatible changes, to force update the symbols file, showing in the error message if the changes are an API break or not, so that it's easy to know whether we just need to update the file or we are breaking the API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.