[Webkit-unassigned] [Bug 101199] Disable registerProtocolHandler on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101199





--- Comment #2 from Peter Beverloo <peter at chromium.org>  2012-11-05 02:49:10 PST ---
(From update of attachment 172300)
View in context: https://bugs.webkit.org/attachment.cgi?id=172300&action=review

Thanks for the patch, Miguel! Please find two nits in-line. You may also want to consider requesting commit-queue, which is useful as you're not a committer yet yourself. You can do this in the patch' Details section, or by supplying the "--request-commit" argument to webkit-patch upload.

> Source/WebKit/chromium/ChangeLog:3
> +        Disable registerProtocolHandler on Android

Since this patch only touches Chromium-specific code, it's best to prefix the bug title with "[Chromium]", especially since there is no more Android port in WebKit.

> Source/WebKit/chromium/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Any line with "(OOPS!)" will make presubmit unhappy. The only exception here is the "Reviewed by NOBODY (OOPS!)" line, which will be filled in automatically by the tools.

In this case, it's important for the reviewer and other members of the Chromium project to understand why registerProtocolHandler is being disabled for Android. A bit of rationale can help here, so something like the following text would be clearer: "Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't actually wired up internally. Disable the feature to avoid breaking feature detection until we can implement it properly."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.