[Webkit-unassigned] [Bug 96592] Ruby text is incorrectly positioned when its writing-mode is changed to vertical after layout is done

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96592


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #171772|review?                     |review-
               Flag|                            |




--- Comment #7 from Hajime Morrita <morrita at google.com>  2012-11-04 17:21:14 PST ---
(From update of attachment 171772)
View in context: https://bugs.webkit.org/attachment.cgi?id=171772&action=review

> LayoutTests/fast/writing-mode/ruby-text-logical-left.html:26
> +      setTimeout(function () {

Although there is no JS style guide for WebKit project, we usually follows one of C++,
that means we does 4-space indent. See other tests as examples.

> LayoutTests/fast/writing-mode/ruby-text-logical-left.html:27
> +        var e = document.getElementById("test1");

Please don't use abbreviation for the variable name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.