[Webkit-unassigned] [Bug 100674] [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 14:42:33 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100674


Christophe Dumez <christophe.dumez at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.dumez at intel.com




--- Comment #26 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-02 14:43:56 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=172138&action=review

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:133
> +        m_pageProxy->setUseFixedLayout(true);

m_pageProxy->setUseFixedLayout(mode == FixedLayoutMode);  on 1 line?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:187
> +    WebCore::IntPoint scrollPosition() const { return m_scrollPosition; }

You could return a const reference here.

> Source/WebKit2/UIProcess/efl/PageClientImplFixedLayout.cpp:51
> +void PageClientImplFixedLayout::initialize()

Now that we have 3 classes, why do we still need this initialise() method? Why can't we move this code to the constructor?

> Source/WebKit2/UIProcess/efl/PageClientImplFixedLayout.h:49
> +

extra line here.

> Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp:89
> +    m_viewImpl->setScrollPosition(IntPoint(contentsPoint.x(), contentsPoint.y()));

We could store IntPoint(contentsPoint.x(), contentsPoint.y()) in a variable to construct it once instead of twice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list