[Webkit-unassigned] [Bug 100674] [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100674





--- Comment #17 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-11-02 03:20:17 PST ---
(From update of attachment 171953)
View in context: https://bugs.webkit.org/attachment.cgi?id=171953&action=review

Think it's worth creating PageClientImplLegacy rather than EwkViewImplLegacy

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:334
> +{

Does the view really need to have all these methods, seems the place of this functionality is inside page client

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:187
> +    virtual float scaleFactor() { return m_pageViewportControllerClient->scaleFactor(); }

should be const

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:188
> +    virtual WebCore::IntPoint scrollPosition() { return m_pageViewportControllerClient->scrollPosition(); }

same here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.