[Webkit-unassigned] [Bug 101021] Web Inspector: add console.clear()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101021


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172003|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-11-02 01:37:45 PST ---
(From update of attachment 172003)
View in context: https://bugs.webkit.org/attachment.cgi?id=172003&action=review

> Source/WebCore/inspector/ConsoleMessage.cpp:115
> +    case ClearConsoleMessageType: return TypeBuilder::Console::ConsoleMessage::Type::Clear;

Drop "Console", it's cleaner.

> Source/WebCore/inspector/front-end/ConsoleMessage.js:80
> +                    this._messageElement = document.createTextNode("console.clear()");

I would say "Console was cleared" with gray. You'll need to put it into WebCore/English.lproj/localizedStrings.js

> LayoutTests/inspector/console/console-clear-function-expected.txt:11
> +console.clear()

Sounds like the source location is missing.

> LayoutTests/inspector/console/console-clear-function.html:22
> +    RuntimeAgent.evaluate("console.clear();", function() {

Use named functions (step1)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.