[Webkit-unassigned] [Bug 99801] Web Inspector: [JSC] implement WorkerScriptDebugServer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 00:58:05 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99801


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #171804|review?                     |review+
               Flag|                            |




--- Comment #10 from Yury Semikhatsky <yurys at chromium.org>  2012-11-02 00:59:27 PST ---
(From update of attachment 171804)
View in context: https://bugs.webkit.org/attachment.cgi?id=171804&action=review

Consider adding a test for the worker debugging functionality. Now that we have support for pure protocol tests (kudos to vivekg) it shouldn't be hard to test worker debugging functionality. See for example the test I recently added for workers: LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html

> Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp:61
> +    recompileAllJSFunctions(0);

recompileAllJSFunctions should only be called when the first listener is being added. It seems that we need to fix this in PageSriptDebugServer as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list