[Webkit-unassigned] [Bug 100826] [Shadow][Refactoring] Using isUnknownPseudoElement() for shadow pseudo id seems confusing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 19:48:59 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100826





--- Comment #5 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-11-01 19:50:22 PST ---
(In reply to comment #4)
> For completely UNKNOWN ids, we can skip using that CSS rule, right? It's because it won't match anything.
> When parsing succeeded, we should already know the type of id.

Yes, that's the win I see.

In terms of naming, I see three types of "unknown" pseudo-elements:

1) CustomPseudoElement --> CUSTOM
2) WebKitPseudoElement --> WEBKIT_CUSTOM
3) UnknownPseudoElement --> UNKNOWN

The interesting bit is that WebKitCustomElement should only match attributes that were set by the UA. We should _not_ allow any random Bob set "-webkit-slider-thumb" on their div and have it matched. That would be bad.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list