[Webkit-unassigned] [Bug 100923] Free GL resources allocated by GraphicsContext3DEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100923





--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-01 05:58:53 PST ---
(From update of attachment 171823)
View in context: https://bugs.webkit.org/attachment.cgi?id=171823&action=review

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:155
> +    if (m_renderStyle == RenderToCurrentGLContext || !m_private)
> +        return;

Couldn't we have a comment here why no freeing is needed in that case?

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:169
> +    } else if (m_attrs.stencil || m_attrs.depth) {
> +
> +#if USE(OPENGL_ES_2)

no newline here sorry.

Why does this have to be a separate "else if". You are chekcing with if's later down

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.