[Webkit-unassigned] [Bug 97427] [EFL][DRT] Support Geolocation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 1 03:38:29 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=97427
Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #171785|review+ |review-
Flag| |
--- Comment #16 from Gyuyoung Kim <gyuyoung.kim at samsung.com> 2012-11-01 03:39:50 PST ---
(From update of attachment 171785)
View in context: https://bugs.webkit.org/attachment.cgi?id=171785&action=review
> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:89
> + WebCore::provideGeolocationTo(page, mock);
Sorry. I missed one. If we add this one to here, we add GeolocationClient twice. One is ewk_view and other is here.
Because, you will add a GeolocationClientEfl to WebCore's supplement in _ewk_view_priv_new, right ? When we run layout test, GeolocationClient will be added twice by this. It might to make assertion.
We have to follow other ports's implementation using a flag. (e.g. s_drt ?)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list