[Webkit-unassigned] [Bug 87991] New: Computed style tests are a maintenance burden on the project

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87991

           Summary: Computed style tests are a maintenance burden on the
                    project
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tony at chromium.org
                CC: eric at webkit.org, darin at apple.com, ap at webkit.org,
                    abarth at webkit.org


The computed style tests enumerate the computed CSS properties.  The tests in particular are these:

fast/css/getComputedStyle/computed-style-without-renderer.html (6 results)
fast/css/getComputedStyle/computed-style.html (7 results)
svg/css/getComputedStyle-basic.xhtml (12 results)

The following seem to be problems:
1) The 3 tests are similar and require similar -expected.txt changes.
2) These tests aren't able to share results across platforms since different platforms have different features enabled.  The property-names.js file tries to work around this, but it doesn't seem to be getting much use.
3) svg/css/getComputedStyle-basic.xhtml exposes the CSS OM, which isn't well spec'ed.  It makes the test output more verbose and harder to update.

Some possible solutions:
1) Maybe we can merge computed-style-without-renderer.html and computed-style.html into a single test?  It would reduce the number of -expected files to update, although would require 2 changes to each one.  I think that's a small improvement.
2) We could do a pass over all the platforms and update property-names.js's propertiesToSkip list.  Maybe once we're down to a single expectations, people will start using the property-names.js file.  The down side is that the propertiesToSkip list would likely be large.
3) We could convert svg/css/getComputedStyle-basic.xhtml to just list property names and initial values like the fast/css tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.