[Webkit-unassigned] [Bug 87953] [SOUP] WebProcess crashes when a download is started from an existing ResourceHandle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87953





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-05-31 09:01:37 PST ---
(In reply to comment #5)
> (From update of attachment 145045 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145045&action=review
> 
> >>> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:154
> >>> +        m_downloadClient->didReceiveResponse(m_resourceHandle.get(), handleInternal->m_response);
> >> 
> >> Is there a chance that data has already been received or the request already failed as well? If that was the case then we'd have to forward those events. Or is the resource handle paused during policy decisions?
> > 
> > Policy decisions happen before data is sent, when the response has been received. If it fails, it's not converted to a download.
> 
> The download client still handles didReceiveData and didFail though...

once the download client has been set as the handle client, if it fails, it will be handled by the download, and of course didReceiveData is handled to write the downloaded data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.