[Webkit-unassigned] [Bug 87853] the imageSmoothingEnabled flag needs to be in the state object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87853





--- Comment #9 from Stephen White <senorblanco at chromium.org>  2012-05-31 08:32:07 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > This is failing on the GTK bots for some reason, even if it looks like something that should work in a cross-platform basis.
> > 
> > Any idea?
> > 
> > The diff:
> > --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/canvas/canvas-imageSmoothingEnabled-expected.txt 
> > +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/canvas/canvas-imageSmoothingEnabled-actual.txt 
> > @@ -23,9 +23,9 @@
> >  PASS left_of_center_pixel.data[1] !== 0 is true
> >  PASS left_of_center_pixel.data[2] !== 0 is true
> >  Test that restoring actually changes smoothing and not just the attribute value. We are restoring to a point where imageSmoothingEnabled is set to false.
> > -PASS left_of_center_pixel.data[0] is 0
> > -PASS left_of_center_pixel.data[1] is 0
> > -PASS left_of_center_pixel.data[2] is 0
> > +FAIL left_of_center_pixel.data[0] should be 0. Was 63.
> > +FAIL left_of_center_pixel.data[1] should be 0. Was 63.
> > +FAIL left_of_center_pixel.data[2] should be 0. Was 63.
> >  PASS successfullyParsed is true
> > 
> >  TEST COMPLETE
> 
> Is it possible that GTK's (cairo's?) implementation of GraphicsContext does not save/restore the ImageInterpolation correctly?

Yes, it looks like PlatformContextCairo stores the interpolation quality directly, and it should be moved to PlatformContextCairo::State instead.  That would be my guess (assuming the GTK port uses Cairo).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.