[Webkit-unassigned] [Bug 87938] [GTK] Avoid unnecessary heap allocations during drag and drop operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87938





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-05-31 08:25:16 PST ---
(In reply to comment #3)
> (From update of attachment 145013 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145013&action=review
> 
> Hrm. I'm not sure if I prefer the new approach. It does avoid an allocation on the heap, but replaces it with an allocation on the stack which is arguably riskier and with the result of creating more code.   Additionally this moves from two places in the code having to create DragData  to six.
> 
> I worry also that the use of position as an in and out parameter could be confusing and would prefer to simply have a getter on DragAndDropHelper.
> 

That's a workaround to use the last motion position instead of the coords passed to drag-data-received, the caller has everything required to build a DragData.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.