[Webkit-unassigned] [Bug 87701] [Qt] REGRESSION(r118616): It made all tests crash in debug mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87701


Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |noam.rosenthal at nokia.com




--- Comment #8 from Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org>  2012-05-31 08:21:59 PST ---
(In reply to comment #7)
> Created an attachment (id=145074)
 --> (https://bugs.webkit.org/attachment.cgi?id=145074&action=review) [details]
> I am here now
> 
> After playing with different combinations, this one seems working. Oszi, could you check it?

I have a couple of questions here: 

1) It's not clear to me that we need weak references for the methods, instead of keeping just references. Once the Instance is removed, we just need to tell the cached methods, if still around, that its associated instance is not there anymore.

2) Do we really need this method cache? Other bridges seems to handle without it.

3) Regardless we land this fix or not now. As proposed before by others before (including Oliver), I think a better long term solution here is to just rewrite the QtRuntimeMethod and subclasses with the JSC API. But in this case I don't see how to keep "Weak" references.

Once I understand (1), I can volunteer to work on (3).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.