[Webkit-unassigned] [Bug 73917] [Qt][WK2] fast/forms/access-key-for-all-elements.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73917


Marcelo Lira <marcelo.lira at openbossa.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcelo.lira at openbossa.org




--- Comment #10 from Marcelo Lira <marcelo.lira at openbossa.org>  2012-05-31 08:19:38 PST ---
(In reply to comment #8)
> (From update of attachment 143652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143652&action=review
> 
> > Source/WebCore/platform/qt/UserAgentQt.cpp:160
> > +        // TODO: using macros from WebKit1 until WebKit2 Qt port versioning is sorted out.
> 
> We use FIXME not TODO :-)
> 
> > Source/WebCore/platform/qt/UserAgentQt.h:28
> > +    static String standardUserAgent(const String &applicationNameForUserAgent);
> 
> defaultUserAgentString makes more sense. The "user agent" is actually the embedding application.
> 
> defaultUserAgentString(const String& userAgentName)

(/me on behalf of Lauro, who is in on his holidays)
Kenneth, I left UserAgentQt::standardUserAgent as it was because it follows the naming on WebPageProxy::standardUserAgent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.