[Webkit-unassigned] [Bug 85527] [Qt][WK2] Add support for multi-select list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85527


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144606|review?                     |review-
               Flag|                            |




--- Comment #18 from Tor Arne Vestbø <vestbo at webkit.org>  2012-05-31 06:45:37 PST ---
(From update of attachment 144606)
View in context: https://bugs.webkit.org/attachment.cgi?id=144606&action=review

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml:24
> +                model.close()

I don't like this change. All the dialogs have accept(), reject(), and dismiss(), where the latter is a neutral "close" and the two former implies the latter.

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_multiSelect.qml:26
> +        Timer {
> +            running: true
> +            interval: 1
> +            onTriggered: {
> +                var selectedIndices = [0,1]
> +                if (model.allowMultiSelect && selectItems){
> +                    for (var i = 0; i <  selectedIndices.length; i++)
> +                        model.accept(selectedIndices[i])
> +                }
> +                model.close();

There's no need for a timer here anymore, you should be able to do the test in  Component.onCompleted: {} like the other dialog tests do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.